Skip to content

fix: remove new badge from monitoring tab#3793

Merged
astandrik merged 2 commits intomainfrom
copilot/remove-new-label-monitoring-tab
Apr 11, 2026
Merged

fix: remove new badge from monitoring tab#3793
astandrik merged 2 commits intomainfrom
copilot/remove-new-label-monitoring-tab

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 10, 2026

The Monitoring tab in Tenant / Diagnostics was still displaying a "New" badge label, which is no longer appropriate.

Changes

  • DiagnosticsPages.ts: Removed the badge property from the monitoring tab definition
  • i18n/en.json: Removed the now-unused value_new: "New" translation key

Greptile Summary

This PR removes the "New" badge label from the Monitoring tab in the Tenant / Diagnostics view by deleting the badge property from the monitoring tab definition and cleaning up the now-unused value_new i18n key.

Confidence Score: 5/5

Safe to merge — change is a straightforward badge removal with no logic impact.

All findings are P2 (dead code cleanup suggestion). The actual change is correct: the badge property and its i18n key are fully removed with no remaining references anywhere in the codebase.

No files require special attention.

Important Files Changed

Filename Overview
src/containers/Tenant/Diagnostics/DiagnosticsPages.ts Removes the badge property from the monitoring tab object; the Badge interface and badge? field on Page remain and are now dead code.
src/containers/Tenant/Diagnostics/i18n/en.json Removes the now-unused value_new: "New" translation key; no other locale files exist, so no stale keys remain.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[DiagnosticsTabs renders tabs] --> B{tab has badge?}
    B -- "Yes (before PR)" --> C[Render tab title + Label badge]
    B -- "No (after PR)" --> D[Render tab title only]
    C --> E[Monitoring tab showed 'New' badge]
    D --> F[Monitoring tab shows title only]
Loading

Comments Outside Diff (1)

  1. src/containers/Tenant/Diagnostics/DiagnosticsPages.ts, line 16-26 (link)

    P2 Unused Badge interface and dead badge infrastructure

    With monitoring being the only tab that ever had a badge, removing it leaves the Badge interface (lines 16–20) and the badge?: Badge field on Page (line 25) as dead code. DiagnosticsTabs.tsx still imports the Page type and conditionally renders the Label component only when badge is truthy — logic that can now never be reached. Per the project convention of removing unused interfaces added during development, consider cleaning up these artifacts alongside this PR.

    Rule Used: Remove unused interfaces and CSS classes that are ... (source)

    Learnt From
    ydb-platform/ydb-embedded-ui#2729

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: src/containers/Tenant/Diagnostics/DiagnosticsPages.ts
    Line: 16-26
    
    Comment:
    **Unused `Badge` interface and dead badge infrastructure**
    
    With `monitoring` being the only tab that ever had a `badge`, removing it leaves the `Badge` interface (lines 16–20) and the `badge?: Badge` field on `Page` (line 25) as dead code. `DiagnosticsTabs.tsx` still imports the `Page` type and conditionally renders the `Label` component only when `badge` is truthy — logic that can now never be reached. Per the project convention of removing unused interfaces added during development, consider cleaning up these artifacts alongside this PR.
    
    **Rule Used:** Remove unused interfaces and CSS classes that are ... ([source](https://app.greptile.com/review/custom-context?memory=dfecc753-e772-4407-a8fa-d7334788fb5a))
    
    **Learnt From**
    [ydb-platform/ydb-embedded-ui#2729](https://github.com/ydb-platform/ydb-embedded-ui/pull/2729)
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
This is a comment left during a code review.
Path: src/containers/Tenant/Diagnostics/DiagnosticsPages.ts
Line: 16-26

Comment:
**Unused `Badge` interface and dead badge infrastructure**

With `monitoring` being the only tab that ever had a `badge`, removing it leaves the `Badge` interface (lines 16–20) and the `badge?: Badge` field on `Page` (line 25) as dead code. `DiagnosticsTabs.tsx` still imports the `Page` type and conditionally renders the `Label` component only when `badge` is truthy — logic that can now never be reached. Per the project convention of removing unused interfaces added during development, consider cleaning up these artifacts alongside this PR.

**Rule Used:** Remove unused interfaces and CSS classes that are ... ([source](https://app.greptile.com/review/custom-context?memory=dfecc753-e772-4407-a8fa-d7334788fb5a))

**Learnt From**
[ydb-platform/ydb-embedded-ui#2729](https://github.com/ydb-platform/ydb-embedded-ui/pull/2729)

How can I resolve this? If you propose a fix, please make it concise.

Reviews (1): Last reviewed commit: "Remove New badge from Monitoring tab" | Re-trigger Greptile

Context used:

  • Rule used - Remove unused interfaces and CSS classes that are ... (source)

Learnt From
ydb-platform/ydb-embedded-ui#2729

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
608 604 0 1 3

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 63.40 MB | Main: 63.40 MB
Diff: 0.24 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copilot AI changed the title [WIP] Remove label New from Monitoring tab Remove "New" badge from Monitoring tab Apr 10, 2026
Copilot AI requested a review from antonkovalenko April 10, 2026 17:39
@astandrik astandrik marked this pull request as ready for review April 11, 2026 08:21
Copilot AI review requested due to automatic review settings April 11, 2026 08:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the outdated “New” badge from the Monitoring tab in Tenant → Diagnostics and cleans up the now-unused i18n key.

Changes:

  • Removed the badge definition from the monitoring tab config.
  • Deleted the unused value_new translation key from Tenant/Diagnostics i18n.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/containers/Tenant/Diagnostics/DiagnosticsPages.ts Drops the Monitoring tab badge configuration so the UI no longer renders the “New” label.
src/containers/Tenant/Diagnostics/i18n/en.json Removes the unused value_new string that was only used by the removed badge.

@astandrik
Copy link
Copy Markdown
Collaborator

@copilot change title to conventional commit message

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 11, 2026

@copilot change title to conventional commit message

The conventional commit title should be: fix: remove "New" badge from monitoring tab — I'm unable to update the PR title directly, but it can be updated manually before merging.

@astandrik astandrik changed the title Remove "New" badge from Monitoring tab fix: remove new badge from monitoring tab Apr 11, 2026
@astandrik astandrik added this pull request to the merge queue Apr 11, 2026
Merged via the queue into main with commit f9176d1 Apr 11, 2026
24 of 27 checks passed
@astandrik astandrik deleted the copilot/remove-new-label-monitoring-tab branch April 11, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove label New from Monitoring tab

4 participants