fix: remove new badge from monitoring tab#3793
Merged
Conversation
Agent-Logs-Url: https://github.com/ydb-platform/ydb-embedded-ui/sessions/a400cf20-adb0-40aa-806b-31b9c50354bc Co-authored-by: antonkovalenko <[email protected]>
Copilot
AI
changed the title
[WIP] Remove label New from Monitoring tab
Remove "New" badge from Monitoring tab
Apr 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the outdated “New” badge from the Monitoring tab in Tenant → Diagnostics and cleans up the now-unused i18n key.
Changes:
- Removed the
badgedefinition from themonitoringtab config. - Deleted the unused
value_newtranslation key from Tenant/Diagnostics i18n.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/containers/Tenant/Diagnostics/DiagnosticsPages.ts | Drops the Monitoring tab badge configuration so the UI no longer renders the “New” label. |
| src/containers/Tenant/Diagnostics/i18n/en.json | Removes the unused value_new string that was only used by the removed badge. |
Collaborator
|
@copilot change title to conventional commit message |
Contributor
Author
The conventional commit title should be: |
astandrik
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Monitoring tab in Tenant / Diagnostics was still displaying a "New" badge label, which is no longer appropriate.
Changes
DiagnosticsPages.ts: Removed thebadgeproperty from themonitoringtab definitioni18n/en.json: Removed the now-unusedvalue_new: "New"translation keyGreptile Summary
This PR removes the "New" badge label from the Monitoring tab in the Tenant / Diagnostics view by deleting the
badgeproperty from themonitoringtab definition and cleaning up the now-unusedvalue_newi18n key.Confidence Score: 5/5
Safe to merge — change is a straightforward badge removal with no logic impact.
All findings are P2 (dead code cleanup suggestion). The actual change is correct: the badge property and its i18n key are fully removed with no remaining references anywhere in the codebase.
No files require special attention.
Important Files Changed
badgeproperty from themonitoringtab object; theBadgeinterface andbadge?field onPageremain and are now dead code.value_new: "New"translation key; no other locale files exist, so no stale keys remain.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[DiagnosticsTabs renders tabs] --> B{tab has badge?} B -- "Yes (before PR)" --> C[Render tab title + Label badge] B -- "No (after PR)" --> D[Render tab title only] C --> E[Monitoring tab showed 'New' badge] D --> F[Monitoring tab shows title only]Comments Outside Diff (1)
src/containers/Tenant/Diagnostics/DiagnosticsPages.ts, line 16-26 (link)Badgeinterface and dead badge infrastructureWith
monitoringbeing the only tab that ever had abadge, removing it leaves theBadgeinterface (lines 16–20) and thebadge?: Badgefield onPage(line 25) as dead code.DiagnosticsTabs.tsxstill imports thePagetype and conditionally renders theLabelcomponent only whenbadgeis truthy — logic that can now never be reached. Per the project convention of removing unused interfaces added during development, consider cleaning up these artifacts alongside this PR.Rule Used: Remove unused interfaces and CSS classes that are ... (source)
Learnt From
ydb-platform/ydb-embedded-ui#2729
Prompt To Fix With AI
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Remove New badge from Monitoring tab" | Re-trigger Greptile
Context used:
Learnt From
ydb-platform/ydb-embedded-ui#2729
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 63.40 MB | Main: 63.40 MB
Diff: 0.24 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information